feat -- table owner categories #2260
Conversation
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
B-T-D
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes and
ozandogrultan
as code owners
Signed-off-by: Ben Dye <[email protected]>
| <ul className="component-list"> | ||
| {section ? ( | ||
| <div> | ||
| <span>{section.label}</span> |
There was a problem hiding this comment.
can we add className="title-3" to this so it looks more like a title?
|
|
||
| const ownerList = hasItems ? ( | ||
| return ( | ||
| <ul className="component-list"> |
There was a problem hiding this comment.
can you add a css class to the <ul> here that sets margin-bottom: $spacer-1 (8px) but then sets it to 0 for the last-child? the larger sections have their own spacing so we want to skip it for the last item
| </div> | ||
| ); | ||
| } | ||
| renderOwnersSection = (section: OwnerCategory | null) => { |
There was a problem hiding this comment.
we might want to consider doing some indication if there are no owners in a certain category. right now those titles look like floating text but isn't fully clear that it is an empty list
There was a problem hiding this comment.
updated -- i used the styling that FrequentUsers uses for "No frequent users exist": https://github.com/amundsen-io/amundsen/blob/main/frontend/amundsen_application/static/js/pages/TableDetailPage/FrequentUsers/index.tsx#L64
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Signed-off-by: Ben Dye <[email protected]>
Description
This PR adds config support for differentiating multiple categories of table owners in the Amundsen UI. For example, if an Amundsen instance wants to differentiate human users who are responsible for remediating operational issues with a table from non-human team or service emails.
To implement this, we propose supporting open-ended owner categories identified by a name and a definition text, to be configured in non-open-source code. The relevant React components are updated to render differently when owner categories are provided, while preserving current behavior for Amundsen instances that don't want to display different owner types differently in the UI.
other_key_valuesfield that already exists on the backend's User modelExample of owners rendered by category (where there's no owner of a configured category for the table, we still show the category name and definition, e.g. no "operational" owners here):
Motivation and Context
At Lyft, we'd like to be able to differentiate human-user table owners--who could actually be contacted to address data quality problems--from non-human owners.
How Has This Been Tested?
Existing unit tests and linting pass. I locally tested using the new configs to have the React app render owners by category.
CheckList